Move printing-related methods from WebFrame to WebLocalFrame.

Move printing-related methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame (sometimes without
realizing this, so the CL changes types to WebLocalFrame in a few
places).  The only exception is in CapturePixelsForPrinting function
in content/shell/test_runner/pixel_dump.cc - the CL adds a CHECK to
verify that layout tests do not run into a scenario unsupported by
the current layout tests harness.

Additionally this CL renames PrintPagesWithBoundaries method
into PrintPagesForTesting.

No intended behavior change.

BUG=416660
Review-Url: https://codereview.chromium.org/2923343005
Cr-Commit-Position: refs/heads/master@{#478731}
Committed: https://chromium.googlesource.com/chromium/src/+/c76f7eb31474f21e1516a88f6f53487e24833894

[Łukasz Anforowicz, 2017-06-08 18:45:41]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 18:46:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-08 19:10:36]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 19:11:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 20:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:59:28]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-08 21:03:42]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-08 21:03:44]

dcheng@, can you PTAL?

https://codereview.chromium.org/2923343005/diff/20001/content/renderer/gpu/gp...
File content/renderer/gpu/gpu_benchmarking_extension.cc (right):

https://codereview.chromium.org/2923343005/diff/20001/content/renderer/gpu/gp...
content/renderer/gpu/gpu_benchmarking_extension.cc:12: #include <vector>
Suggested by git cl lint for std::unique_ptr and for std::vector.

https://codereview.chromium.org/2923343005/diff/20001/content/renderer/gpu/gp...
content/renderer/gpu/gpu_benchmarking_extension.cc:490: DCHECK_GT(page_shrink,
0);
Suggested by git cl lint.

https://codereview.chromium.org/2923343005/diff/20001/content/shell/test_runn...
File content/shell/test_runner/pixel_dump.cc (right):

https://codereview.chromium.org/2923343005/diff/20001/content/shell/test_runn...
content/shell/test_runner/pixel_dump.cc:8: #include <utility>
Suggested by git cl lint for std::move.

https://codereview.chromium.org/2923343005/diff/20001/content/shell/test_runn...
content/shell/test_runner/pixel_dump.cc:52: explicit CaptureCallback(
Suggested by git cl lint

[dcheng, 2017-06-09 06:41:58]

lgtm

[Łukasz Anforowicz, 2017-06-09 14:47:09]

lukasza@chromium.org changed reviewers:
+ nick@chromium.org, scottbyer@chromium.org

[Łukasz Anforowicz, 2017-06-09 14:47:10]

+scottbyer@ for //components/printing
+nick@ for //content

[ncarter (slow), 2017-06-09 18:17:09]

lgtm

[Scott Byer, 2017-06-12 16:31:01]

lgtm

[Łukasz Anforowicz, 2017-06-12 17:58:36]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-12 17:58:37]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2923343005/#ps40001
(title: "Rebasing...")

[commit-bot: I haz the power, 2017-06-12 17:59:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:59:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497290316873040,
"parent_rev": "5097bdd411fe4f7e557ac0fb9dcc3074954e0cc2", "commit_rev":
"c76f7eb31474f21e1516a88f6f53487e24833894"}

[commit-bot: I haz the power, 2017-06-12 19:59:26]

Description was changed from

==========
Move printing-related methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame (sometimes without
realizing this, so the CL changes types to WebLocalFrame in a few
places).  The only exception is in CapturePixelsForPrinting function
in content/shell/test_runner/pixel_dump.cc - the CL adds a CHECK to
verify that layout tests do not run into a scenario unsupported by
the current layout tests harness.

Additionally this CL renames PrintPagesWithBoundaries method
into PrintPagesForTesting.

No intended behavior change.

BUG=416660
==========

to

==========
Move printing-related methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame (sometimes without
realizing this, so the CL changes types to WebLocalFrame in a few
places).  The only exception is in CapturePixelsForPrinting function
in content/shell/test_runner/pixel_dump.cc - the CL adds a CHECK to
verify that layout tests do not run into a scenario unsupported by
the current layout tests harness.

Additionally this CL renames PrintPagesWithBoundaries method
into PrintPagesForTesting.

No intended behavior change.

BUG=416660

Review-Url: https://codereview.chromium.org/2923343005
Cr-Commit-Position: refs/heads/master@{#478731}
Committed:
https://chromium.googlesource.com/chromium/src/+/c76f7eb31474f21e1516a88f6f53...
==========

[commit-bot: I haz the power, 2017-06-12 19:59:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c76f7eb31474f21e1516a88f6f53...