Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

Issue 2923343005: Move printing-related methods from WebFrame to WebLocalFrame. (Closed)
Patch Set: Rebasing... Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
index b93512a7c4a01ecc754057aefb8ec3b9b54b5b10..18d9667e9ac5fd11789a4bf363dff7ad39acd2b4 100644
--- a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
@@ -246,12 +246,12 @@ TEST_F(WebPluginContainerTest, PrintOnePage) {
TestPluginWebFrameClient
plugin_web_frame_client; // Must outlive webViewHelper.
FrameTestHelpers::WebViewHelper web_view_helper;
- WebView* web_view = web_view_helper.InitializeAndLoad(
+ WebViewBase* web_view = web_view_helper.InitializeAndLoad(
base_url_ + "test.pdf", true, &plugin_web_frame_client);
DCHECK(web_view);
web_view->UpdateAllLifecyclePhases();
RunPendingTasks();
- WebFrame* frame = web_view->MainFrame();
+ WebLocalFrame* frame = web_view->MainFrameImpl();
WebPrintParams print_params;
print_params.print_content_area.width = 500;
@@ -270,12 +270,12 @@ TEST_F(WebPluginContainerTest, PrintAllPages) {
TestPluginWebFrameClient
plugin_web_frame_client; // Must outlive webViewHelper.
FrameTestHelpers::WebViewHelper web_view_helper;
- WebView* web_view = web_view_helper.InitializeAndLoad(
+ WebViewBase* web_view = web_view_helper.InitializeAndLoad(
base_url_ + "test.pdf", true, &plugin_web_frame_client);
DCHECK(web_view);
web_view->UpdateAllLifecyclePhases();
RunPendingTasks();
- WebFrame* frame = web_view->MainFrame();
+ WebLocalFrame* frame = web_view->MainFrameImpl();
WebPrintParams print_params;
print_params.print_content_area.width = 500;
@@ -283,8 +283,7 @@ TEST_F(WebPluginContainerTest, PrintAllPages) {
frame->PrintBegin(print_params);
PaintRecorder recorder;
- frame->PrintPagesWithBoundaries(recorder.beginRecording(IntRect()),
- WebSize());
+ frame->PrintPagesForTesting(recorder.beginRecording(IntRect()), WebSize());
frame->PrintEnd();
DCHECK(plugin_web_frame_client.PrintedAtLeastOnePage());
}
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698