Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2923333002: Generate StyleRareNonInheritedData in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/name_utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index f9773d2f7537984066a4d669f817979c83cb2518..4daaaeb142f9893ff3d32238aeecf81bd2112bf7 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -24,12 +24,20 @@ from itertools import chain
# https://codereview.chromium.org/2841413002
# TODO(shend): Put alignment sizes into code form, rather than linking to a CL which may disappear.
ALIGNMENT_ORDER = [
+ # Aligns like double
'double',
- 'AtomicString', 'RefPtr', 'Persistent', 'Font', 'FillLayer', 'NinePieceImage', # Aligns like a pointer (can be 32 or 64 bits)
- 'LengthBox', 'LengthSize', 'Length', 'TextSizeAdjust', 'TabSize', 'float',
- 'StyleColor', 'Color', 'LayoutUnit', 'unsigned', 'int',
+ # Aligns like a pointer (can be 32 or 64 bits)
+ 'AtomicString', 'DataRef', 'RefPtr', 'DataPersistent', 'Persistent', 'std::unique_ptr',
+ 'Vector<String>', 'Font', 'FillLayer', 'NinePieceImage',
+ # Aligns like float
+ 'LengthBox', 'LengthSize', 'FloatSize', 'LengthPoint', 'Length', 'TextSizeAdjust', 'TabSize', 'float',
+ # Aligns like int
+ 'StyleColor', 'Color', 'LayoutUnit', 'LineClampValue', 'OutlineValue', 'unsigned', 'int',
+ # Aligns like short
'short',
- 'uint8_t', 'char',
+ # Aligns like char
+ 'StyleSelfAlignmentData', 'StyleContentAlignmentData', 'uint8_t', 'char',
+ # Aligns like bool
'bool'
]
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/name_utilities.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698