Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2923243003: Merge-60 [Payments] Move the RequestedInformation metric to native. (Closed)

Created:
3 years, 6 months ago by sebsg
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Merge-60 [Payments] Move the RequestedInformation metric to native. Bug: 729085 Change-Id: Ie2ad1325bc1dc4837949ffc9b679f9063ccbd9b0 Reviewed-on: https://chromium-review.googlesource.com/522903 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>; Reviewed-by: Ganggui Tang <gogerald@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477040} Review-Url: https://codereview.chromium.org/2923243003 . Cr-Commit-Position: refs/branch-heads/3112@{#201} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/01029cab15a68d6010514ff9ad12256dc49a579a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -283 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java View 1 chunk +0 lines, -221 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/payments/android/journey_logger_android.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/payments/android/journey_logger_android.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M components/payments/core/journey_logger.h View 3 chunks +12 lines, -0 lines 0 comments Download
M components/payments/core/journey_logger.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sebsg
3 years, 6 months ago (2017-06-06 20:09:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01029cab15a68d6010514ff9ad12256dc49a579a.

Powered by Google App Engine
This is Rietveld 408576698