chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2923243003: Merge-60 [Payments] Move the RequestedInformation metric to native.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2923243003: Merge-60 [Payments] Move the RequestedInformation metric to native. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index f1f04590ac619e095e3d3b777f79228c16eb217c..b1605e7ff026c6f4e1c11948a813575b1a5985dd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -442,8 +442,8 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

return;

}

- PaymentRequestMetrics.recordRequestedInformationHistogram(

- mRequestPayerEmail, mRequestPayerPhone, mRequestShipping, mRequestPayerName);

+ mJourneyLogger.setRequestedInformation(

+ mRequestShipping, mRequestPayerEmail, mRequestPayerPhone, mRequestPayerName);

if (OriginSecurityChecker.isSchemeCryptographic(mWebContents.getLastCommittedUrl())

&& !SslValidityChecker.isSslCertificateValid(mWebContents)) {