Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 2923023002: DevTools: fix BUILD.gn for network_priorities_module (Closed)

Created:
3 years, 6 months ago by chenwilliam
Modified:
3 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix BUILD.gn for network_priorities_module My previous CL https://codereview.chromium.org/2915883002/ accidentally broke Network panel. I manually tweaked something (after running the script transformation) which broke it. As a follow-up, I'll create an invariant check to avoid these types of mistakes (crbug.com/729646). BUG=729011 Review-Url: https://codereview.chromium.org/2923023002 Cr-Commit-Position: refs/heads/master@{#477141} Committed: https://chromium.googlesource.com/chromium/src/+/4f25b929845640a0324c8e04b77cffb7b7b76e08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
chenwilliam
Please take a look - this fixes a P0 bug in Canary I caused :(
3 years, 6 months ago (2017-06-05 18:23:58 UTC) #2
dgozman
lgtm
3 years, 6 months ago (2017-06-05 18:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923023002/1
3 years, 6 months ago (2017-06-05 18:52:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310615)
3 years, 6 months ago (2017-06-05 22:36:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923023002/1
3 years, 6 months ago (2017-06-05 22:59:38 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 01:14:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f25b929845640a0324c8e04b77c...

Powered by Google App Engine
This is Rietveld 408576698