DevTools: prepare to unify Network and CPU throttling UI

DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a
dubious home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262
Review-Url: https://codereview.chromium.org/2915883002
Cr-Commit-Position: refs/heads/master@{#476156}
Committed: https://chromium.googlesource.com/chromium/src/+/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de

[chenwilliam, 2017-05-31 19:20:51]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[chenwilliam, 2017-05-31 19:20:52]

ptal

https://codereview.chromium.org/2915883002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network_conditions/module.json
(left):

https://codereview.chromium.org/2915883002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network_conditions/module.json:4:
"type": "setting",
FYI, I had to manually move this b/c the extract_module script didn't properly
move this (because it doesn't have a namespaced identifier which is how it moves
the other extensions) but you get a runtime error when a setting is missing.

[dgozman, 2017-05-31 20:05:32]

https://codereview.chromium.org/2915883002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js
(right):

https://codereview.chromium.org/2915883002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js:9:
MobileThrottling.uiLabelForPriority = function(priority) {
This one does not belong to MobileThrottling :-) Let's find a better place!

[chenwilliam, 2017-05-31 21:45:58]

Description was changed from

==========
DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262
==========

to

==========
DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a dubious
home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262
==========

[chenwilliam, 2017-05-31 21:46:12]

Description was changed from

==========
DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a dubious
home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262
==========

to

==========
DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a
dubious home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262
==========

[chenwilliam, 2017-05-31 22:23:12]

ptal

https://codereview.chromium.org/2915883002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js
(right):

https://codereview.chromium.org/2915883002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkPriorities.js:9:
MobileThrottling.uiLabelForPriority = function(priority) {
On 2017/05/31 20:05:32, dgozman wrote:
> This one does not belong to MobileThrottling :-) Let's find a better place!

You're right! I made it into a new module "network_priorities" b/c network and
timeline both depend on it.

[dgozman, 2017-05-31 22:34:41]

lgtm

[chenwilliam, 2017-05-31 22:37:38]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-05-31 22:37:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2915883002/#ps60001
(title: "a missing space!")

[commit-bot: I haz the power, 2017-05-31 22:38:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 23:51:50]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chenwilliam, 2017-05-31 23:59:26]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-05-31 23:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2915883002/#ps80001
(title: "gs")

[commit-bot: I haz the power, 2017-06-01 00:00:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 02:29:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496275166627610,
"parent_rev": "ce954697f872bb3f9baafc7e49655e48a2121e0d", "commit_rev":
"6f9400d2dce36b995fa0da47ca25c3c2bf0b18de"}

[commit-bot: I haz the power, 2017-06-01 02:29:26]

Description was changed from

==========
DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a
dubious home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262
==========

to

==========
DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a
dubious home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG=728262

Review-Url: https://codereview.chromium.org/2915883002
Cr-Commit-Position: refs/heads/master@{#476156}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f9400d2dce36b995fa0da47ca25...
==========

[commit-bot: I haz the power, 2017-06-01 02:29:28]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6f9400d2dce36b995fa0da47ca25...