Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2922973004: [ObjC ARC] Converts ios/web/public/test/fakes:fakes to ARC. (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, liaoyuke+watch_chromium.org, stkhapugin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web/public/test/fakes:fakes to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2922973004 Cr-Commit-Position: refs/heads/master@{#477325} Committed: https://chromium.googlesource.com/chromium/src/+/62751ceeb02adc855c96e93127c1bee6c6dc9c33

Patch Set 1 #

Patch Set 2 : remove .gn change #

Patch Set 3 : fix header #

Patch Set 4 : scoped_nsobject in .h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -44 lines) Patch
M ios/web/public/test/fakes/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/fakes/crw_test_js_injection_receiver.mm View 3 chunks +12 lines, -10 lines 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_java_script_dialog_presenter.h View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M ios/web/public/test/fakes/test_java_script_dialog_presenter.mm View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M ios/web/public/test/fakes/test_native_content.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M ios/web/public/test/fakes/test_native_content_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_navigation_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_client.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ios/web/public/test/fakes/test_web_client.mm View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.mm View 1 2 4 chunks +9 lines, -5 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_delegate.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_delegate.mm View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_view_content_view.mm View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
baxley
3 years, 6 months ago (2017-06-05 22:42:31 UTC) #5
kkhorimoto
lgtm!
3 years, 6 months ago (2017-06-05 22:54:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922973004/60001
3 years, 6 months ago (2017-06-06 17:10:49 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 17:28:52 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/62751ceeb02adc855c96e93127c1...

Powered by Google App Engine
This is Rietveld 408576698