Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: ios/web/public/test/fakes/test_java_script_dialog_presenter.h

Issue 2922973004: [ObjC ARC] Converts ios/web/public/test/fakes:fakes to ARC. (Closed)
Patch Set: scoped_nsobject in .h Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/fakes/test_java_script_dialog_presenter.h
diff --git a/ios/web/public/test/fakes/test_java_script_dialog_presenter.h b/ios/web/public/test/fakes/test_java_script_dialog_presenter.h
index 8abb8535ad40220e5ca8da5d38bd0b75cad1c379..d6ab838f4c1718a11311b4f9aff85faa29d94d16 100644
--- a/ios/web/public/test/fakes/test_java_script_dialog_presenter.h
+++ b/ios/web/public/test/fakes/test_java_script_dialog_presenter.h
@@ -8,7 +8,6 @@
#include <vector>
#import "ios/web/public/java_script_dialog_presenter.h"
-#import "base/mac/scoped_nsobject.h"
namespace web {
@@ -19,8 +18,8 @@ struct TestJavaScriptDialog {
WebState* web_state = nullptr;
GURL origin_url;
JavaScriptDialogType java_script_dialog_type;
- base::scoped_nsobject<NSString> message_text;
- base::scoped_nsobject<NSString> default_prompt_text;
+ NSString* message_text;
+ NSString* default_prompt_text;
};
// Test presenter to check that the JavaScriptDialogPresenter methods are called
@@ -55,14 +54,14 @@ class TestJavaScriptDialogPresenter : public JavaScriptDialogPresenter {
// Sets |user_input| argument to be used for RunJavaScriptDialog callback.
void set_callback_user_input_argument(NSString* user_input) {
- callback_user_input_argument_.reset(user_input);
+ callback_user_input_argument_ = user_input;
}
private:
bool cancel_dialogs_called_ = false;
std::vector<TestJavaScriptDialog> requested_dialogs_;
bool callback_success_argument_ = false;
- base::scoped_nsobject<NSString> callback_user_input_argument_;
+ NSString* callback_user_input_argument_;
};
} // namespace web

Powered by Google App Engine
This is Rietveld 408576698