Data Reduction Proxy: Remove duplicate functions

components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
index b329f5f1cb3e4fabc5330d3e375f550c299ca01b..0cd1ea2e081bbbe189dab3092239f66ce4b7175d 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
@@ -17,6 +17,7 @@
 #include "base/threading/thread_checker.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_service_observer.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/prefs/pref_member.h"
 #include "url/gurl.h"
 
@@ -172,7 +173,7 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver {
   // Returns true if the data reduction proxy promo may be shown.
   // This is independent of whether the data reduction proxy is allowed.
   bool PromoAllowed() const {

[megjablon, 2017/06/02 23:01:50]

It doesn't look like this called from anywhere other than
data_reduction_proxy_settings_android.cc. Can we remove this method and just
call drp::params::IsIncludedInPromoFieldTrial() there?

[tbansal1, 2017/06/05 13:48:24]

Done.

-    return promo_allowed_;
+    return data_reduction_proxy::params::IsIncludedInPromoFieldTrial();
   }
 
   DataReductionProxyService* data_reduction_proxy_service() {
@@ -281,11 +282,6 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver {
   // IO object calls will be performed at that time.
   bool deferred_initialization_;
 
-  // The following values are cached in order to access the values on the
-  // correct thread.
-  bool allowed_;
-  bool promo_allowed_;
-
   // The number of requests to reload the page with images from the Lo-Fi
   // UI until Lo-Fi is disabled for the remainder of the session.
   int lo_fi_user_requests_for_images_per_session_;