components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc - Issue 2922663002: Data Reduction Proxy: Remove duplicate functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

Issue 2922663002: Data Reduction Proxy: Remove duplicate functions (Closed)

Patch Set: ps Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

index b07e7dd8c8bbdafba501863d38e0ea58852e0d19..3546231180a29e8d662643a08f50d37fc9f9a8f2 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

@@ -54,7 +54,6 @@ const char kDataReductionPassThroughHeader[] =

DataReductionProxySettings::DataReductionProxySettings()

: unreachable_(false),

deferred_initialization_(false),

- promo_allowed_(false),

data_reduction_proxy_enabled_pref_name_(),

prefs_(NULL),

config_(nullptr),

@@ -81,7 +80,6 @@ void DataReductionProxySettings::InitPrefMembers() {

void DataReductionProxySettings::UpdateConfigValues() {

megjablon 2017/06/02 23:01:50 Remove this method.

tbansal1 2017/06/05 13:48:24 More cleanup. Yay! Done.

DCHECK(config_);

- promo_allowed_ = config_->promo_allowed();

}

void DataReductionProxySettings::InitDataReductionProxySettings(