Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2922433002: [arm] Clean up disabling of sharing code target entries. (Closed)

Created:
3 years, 6 months ago by georgia.kouveli
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Clean up disabling of sharing code target entries. This fixes an issue with ful-codegen where code target entries for the OSR check were being incorrectly shared. We now explicitly disable sharing of code target constant pool entries for full-codegen and for calls to builtins from WASM code, using a scope. BUG=chromium:725743 Review-Url: https://codereview.chromium.org/2922433002 Cr-Commit-Position: refs/heads/master@{#45661} Committed: https://chromium.googlesource.com/v8/v8/+/6a99238b9004c8e14b7f86734ef071eac8198212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -10 lines) Patch
M src/arm/assembler-arm.h View 5 chunks +52 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-725743.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
georgia.kouveli
3 years, 6 months ago (2017-06-01 10:39:02 UTC) #2
Michael Starzinger
LGTM. Thanks!
3 years, 6 months ago (2017-06-01 11:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922433002/1
3 years, 6 months ago (2017-06-01 12:47:33 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 13:18:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6a99238b9004c8e14b7f86734ef071eac81...

Powered by Google App Engine
This is Rietveld 408576698