Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2922433002: [arm] Clean up disabling of sharing code target entries. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | test/mjsunit/compiler/regress-725743.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/assembler-inl.h" 7 #include "src/assembler-inl.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/builtins/builtins-constructor.h" 10 #include "src/builtins/builtins-constructor.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // o cp: our context 102 // o cp: our context
103 // o pp: our caller's constant pool pointer (if enabled) 103 // o pp: our caller's constant pool pointer (if enabled)
104 // o fp: our caller's frame pointer 104 // o fp: our caller's frame pointer
105 // o sp: stack pointer 105 // o sp: stack pointer
106 // o lr: return address 106 // o lr: return address
107 // 107 //
108 // The function builds a JS frame. Please see JavaScriptFrameConstants in 108 // The function builds a JS frame. Please see JavaScriptFrameConstants in
109 // frames-arm.h for its layout. 109 // frames-arm.h for its layout.
110 void FullCodeGenerator::Generate() { 110 void FullCodeGenerator::Generate() {
111 CompilationInfo* info = info_; 111 CompilationInfo* info = info_;
112 // Block sharing of code target entries. The interrupt checks must be
113 // possible to patch individually, and replacing code with a debug version
114 // relies on RelocInfo not being shared.
115 Assembler::BlockCodeTargetSharingScope block_code_target_sharing(masm_);
112 profiling_counter_ = isolate()->factory()->NewCell( 116 profiling_counter_ = isolate()->factory()->NewCell(
113 Handle<Smi>(Smi::FromInt(FLAG_interrupt_budget), isolate())); 117 Handle<Smi>(Smi::FromInt(FLAG_interrupt_budget), isolate()));
114 SetFunctionPosition(literal()); 118 SetFunctionPosition(literal());
115 Comment cmnt(masm_, "[ function compiled by full code generator"); 119 Comment cmnt(masm_, "[ function compiled by full code generator");
116 120
117 ProfileEntryHookStub::MaybeCallEntryHook(masm_); 121 ProfileEntryHookStub::MaybeCallEntryHook(masm_);
118 122
119 if (FLAG_debug_code && info->ExpectsJSReceiverAsReceiver()) { 123 if (FLAG_debug_code && info->ExpectsJSReceiverAsReceiver()) {
120 int receiver_offset = info->scope()->num_parameters() * kPointerSize; 124 int receiver_offset = info->scope()->num_parameters() * kPointerSize;
121 __ ldr(r2, MemOperand(sp, receiver_offset)); 125 __ ldr(r2, MemOperand(sp, receiver_offset));
(...skipping 2726 matching lines...) Expand 10 before | Expand all | Expand 10 after
2848 DCHECK(interrupt_address == 2852 DCHECK(interrupt_address ==
2849 isolate->builtins()->OnStackReplacement()->entry()); 2853 isolate->builtins()->OnStackReplacement()->entry());
2850 return ON_STACK_REPLACEMENT; 2854 return ON_STACK_REPLACEMENT;
2851 } 2855 }
2852 2856
2853 2857
2854 } // namespace internal 2858 } // namespace internal
2855 } // namespace v8 2859 } // namespace v8
2856 2860
2857 #endif // V8_TARGET_ARCH_ARM 2861 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | test/mjsunit/compiler/regress-725743.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698