Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2922183002: DevTools: the sources debug toolbar buttons should not be drag targets (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

DevTools: the sources debug toolbar buttons should not be drag targets BUG=728789 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2915013003 Cr-Original-Commit-Position: refs/heads/master@{#476500} Review-Url: https://codereview.chromium.org/2922183002 Cr-Commit-Position: refs/branch-heads/3112@{#171} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c0d1592d03d65b6cf06887617a64417618cbc80d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
luoe
This merge commit to M60 needs a committer's approval to land. Merge applied cleanly without ...
3 years, 6 months ago (2017-06-05 17:42:34 UTC) #2
pfeldman
lgtm
3 years, 6 months ago (2017-06-05 23:08:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922183002/1
3 years, 6 months ago (2017-06-05 23:09:29 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-05 23:09:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922183002/1
3 years, 6 months ago (2017-06-05 23:35:08 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 23:35:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0d1592d03d65b6cf06887617a64...

Powered by Google App Engine
This is Rietveld 408576698