DevTools: the sources debug toolbar buttons should not be drag targets

DevTools: the sources debug toolbar buttons should not be drag targets

BUG=728789
Review-Url: https://codereview.chromium.org/2915013003
Cr-Commit-Position: refs/heads/master@{#476500}
Committed: https://chromium.googlesource.com/chromium/src/+/e7b341c528a738a53a71ce8f3090f82805557dcc

[luoe, 2017-06-01 21:11:36]

Description was changed from

==========
DevTools: the sources debug toolbar buttons should not be drag targets

BUG=
==========

to

==========
DevTools: the sources debug toolbar buttons should not be drag targets

BUG=728789
==========

[luoe, 2017-06-01 21:11:48]

luoe@chromium.org changed reviewers:
+ pfeldman@chromium.org

[luoe, 2017-06-01 21:11:48]

Please take a look

[pfeldman, 2017-06-01 21:26:56]

lgtm

https://codereview.chromium.org/2915013003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right):

https://codereview.chromium.org/2915013003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:199: contentElement()
{
Let's be more specific and name it gripElementForResize() in order to maintain
illusion of shadow encapsulation.

[luoe, 2017-06-01 21:32:07]

ptal

https://codereview.chromium.org/2915013003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right):

https://codereview.chromium.org/2915013003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:199: contentElement()
{
On 2017/06/01 21:26:56, pfeldman wrote:
> Let's be more specific and name it gripElementForResize() in order to maintain
> illusion of shadow encapsulation.

Done, good idea.

[luoe, 2017-06-01 21:32:28]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-06-01 21:32:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2915013003/#ps20001
(title: "ac")

[commit-bot: I haz the power, 2017-06-01 21:33:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 22:43:08]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2017-06-01 23:24:32]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:25:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:35:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496359472923430,
"parent_rev": "00471e4dc17aed2e8aea47b4df93162f81cdbedf", "commit_rev":
"e7b341c528a738a53a71ce8f3090f82805557dcc"}

[commit-bot: I haz the power, 2017-06-02 00:35:30]

Description was changed from

==========
DevTools: the sources debug toolbar buttons should not be drag targets

BUG=728789
==========

to

==========
DevTools: the sources debug toolbar buttons should not be drag targets

BUG=728789

Review-Url: https://codereview.chromium.org/2915013003
Cr-Commit-Position: refs/heads/master@{#476500}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7b341c528a738a53a71ce8f3090...
==========

[commit-bot: I haz the power, 2017-06-02 00:35:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7b341c528a738a53a71ce8f3090...