Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2921943002: Fix GS URL regex (Closed)

Created:
3 years, 6 months ago by nodir
Modified:
3 years, 6 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : plus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M client/utils/net.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
nodir
PTAL
3 years, 6 months ago (2017-06-02 17:20:24 UTC) #1
M-A Ruel
https://codereview.chromium.org/2921943002/diff/1/client/utils/net.py File client/utils/net.py (right): https://codereview.chromium.org/2921943002/diff/1/client/utils/net.py#newcode72 client/utils/net.py:72: GS_STORAGE_HOST_URL_RE = re.compile(r'https://(.*\.)?storage\.googleapis\.com') It should be a + instead ...
3 years, 6 months ago (2017-06-02 17:26:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921943002/20001
3 years, 6 months ago (2017-06-02 17:28:01 UTC) #6
nodir
https://codereview.chromium.org/2921943002/diff/1/client/utils/net.py File client/utils/net.py (right): https://codereview.chromium.org/2921943002/diff/1/client/utils/net.py#newcode72 client/utils/net.py:72: GS_STORAGE_HOST_URL_RE = re.compile(r'https://(.*\.)?storage\.googleapis\.com') On 2017/06/02 17:26:23, M-A Ruel wrote: ...
3 years, 6 months ago (2017-06-02 17:28:03 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 17:30:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/4b43f73977f9a432219b48f0e7548f2a6e3e2ab5

Powered by Google App Engine
This is Rietveld 408576698