Fix GS URL regex

client/utils/net.py

 # Copyright 2013 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Classes and functions for generic network communication over HTTP."""
 
 import cookielib
 import httplib
 import itertools
 import json
@@ skipping 51 matching lines @@
 # Content type -> function that encodes a request body.
 CONTENT_ENCODERS = {
   URL_ENCODED_FORM_CONTENT_TYPE:
     urllib.urlencode,
   JSON_CONTENT_TYPE:
     lambda x: json.dumps(x, sort_keys=True, separators=(',', ':')),
 }
 
 
 # Google Storage URL regular expression.
-GS_STORAGE_HOST_URL_RE = re.compile(r'https://.*\.storage\.googleapis\.com')
+GS_STORAGE_HOST_URL_RE = re.compile(r'https://(.*\.)?storage\.googleapis\.com')

[M-A Ruel, 2017/06/02 17:26:23]

It should be a + instead of a *, then lgtm

[nodir, 2017/06/02 17:28:03]

Done.

 
 # Global (for now) map: server URL (http://example.com) -> HttpService instance.
 # Used by get_http_service to cache HttpService instances.
 _http_services = {}
 _http_services_lock = threading.Lock()
 
 # This lock ensures that user won't be confused with multiple concurrent
 # login prompts.
 _auth_lock = threading.Lock()
 
@@ skipping 719 matching lines @@
     attemp_obj = RetryAttempt(attempt, remaining)
     yield attemp_obj
     if attemp_obj.skip_sleep:
       continue
     # Only sleep if we are going to try again.
     if max_attempts and attempt != max_attempts - 1:
       remaining = (timeout - (current_time() - start)) if timeout else None
       if remaining is not None and remaining < 0:
         break
       sleep_before_retry(attempt, remaining)