Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2921903003: Remove base::NonThreadSafe now that all users are gone!! (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
danakj, Lei Zhang
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, rogerm+autofillwatch_chromium.org, browser-components-watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, sebsg+autofillwatch_chromium.org, chromoting-reviews_chromium.org, jam, net-reviews_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, xjz+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, Randy Smith (Not in Mondays), loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, sync-reviews_chromium.org, rjkroege, feature-media-reviews_chromium.org, mathp+autofillwatch_chromium.org, avayvod+watch_chromium.org, estade+watch_chromium.org, cc-bugs_chromium.org, isheriff+watch_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::NonThreadSafe now that all users are gone!! And get rid of the few already unused includes of non_thread_safe.h BUG=676387 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=gab@chromium.org (for unused includes) TBR=thestig@chromium.org (for removing unused NonThreadSafe) Review-Url: https://codereview.chromium.org/2921903003 Cr-Commit-Position: refs/heads/master@{#477305} Committed: https://chromium.googlesource.com/chromium/src/+/c64944c2f2b156865e2936879d9ca12a972a5501

Patch Set 1 #

Patch Set 2 : rebase on remaining dependencies #

Patch Set 3 : IWYU #

Patch Set 4 : rebase on r477274 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -290 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -8 lines 0 comments Download
M base/BUILD.gn View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M base/ios/weak_nsobject.h View 1 chunk +0 lines, -1 line 0 comments Download
D base/threading/non_thread_safe.h View 1 chunk +0 lines, -45 lines 0 comments Download
D base/threading/non_thread_safe_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D base/threading/non_thread_safe_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D base/threading/non_thread_safe_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M base/threading/thread_checker_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_job_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/impl/sync_system_resources.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/sync_stopped_reporter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/net/server_connection_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/ssl_host_state_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/net/pacing/paced_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/vaapi_jpeg_decode_accelerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/it2me/it2me_confirmation_dialog_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/transport.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/quota/usage_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/android/view_configuration.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (20 generated)
gab
Dana PTaL, W0000000000000000000000000000T! Will TBR self instead of bothering owners for straggling includes.
3 years, 6 months ago (2017-06-02 19:26:06 UTC) #4
gab
+Lei, looks like Dana is away
3 years, 6 months ago (2017-06-05 18:11:44 UTC) #14
gab
On 2017/06/05 18:11:44, gab wrote: > +Lei, looks like Dana is away TBR thestig since ...
3 years, 6 months ago (2017-06-06 13:31:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921903003/60001
3 years, 6 months ago (2017-06-06 13:31:31 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/456592)
3 years, 6 months ago (2017-06-06 13:39:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921903003/80001
3 years, 6 months ago (2017-06-06 14:01:36 UTC) #24
danakj
base LGTM
3 years, 6 months ago (2017-06-06 15:44:51 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/c64944c2f2b156865e2936879d9ca12a972a5501
3 years, 6 months ago (2017-06-06 16:10:12 UTC) #28
Lei Zhang
3 years, 6 months ago (2017-06-06 21:20:34 UTC) #29
Message was sent while issue was closed.
lgtm

I was gone too...

Powered by Google App Engine
This is Rietveld 408576698