Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Side by Side Diff: PRESUBMIT.py

Issue 2921903003: Remove base::NonThreadSafe now that all users are gone!! (Closed)
Patch Set: rebase on r477274 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 'BrowserThread::GetBlockingPool', 324 'BrowserThread::GetBlockingPool',
325 ( 325 (
326 'Use base/task_scheduler/post_task.h instead of the blocking pool. See', 326 'Use base/task_scheduler/post_task.h instead of the blocking pool. See',
327 'mapping between both APIs in content/public/browser/browser_thread.h.', 327 'mapping between both APIs in content/public/browser/browser_thread.h.',
328 'For questions, contact base/task_scheduler/OWNERS.', 328 'For questions, contact base/task_scheduler/OWNERS.',
329 ), 329 ),
330 True, 330 True,
331 (), 331 (),
332 ), 332 ),
333 ( 333 (
334 'base::NonThreadSafe',
335 (
336 'base::NonThreadSafe is deprecated.',
337 ),
338 True,
339 (),
340 ),
341 (
342 'base::SequenceChecker', 334 'base::SequenceChecker',
343 ( 335 (
344 'Consider using SEQUENCE_CHECKER macros instead of the class directly.', 336 'Consider using SEQUENCE_CHECKER macros instead of the class directly.',
345 ), 337 ),
346 False, 338 False,
347 (), 339 (),
348 ), 340 ),
349 ( 341 (
350 'base::ThreadChecker', 342 'base::ThreadChecker',
351 ( 343 (
(...skipping 2162 matching lines...) Expand 10 before | Expand all | Expand 10 after
2514 output_api, 2506 output_api,
2515 json_url='http://chromium-status.appspot.com/current?format=json')) 2507 json_url='http://chromium-status.appspot.com/current?format=json'))
2516 2508
2517 results.extend( 2509 results.extend(
2518 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2510 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2519 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2511 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2520 input_api, output_api)) 2512 input_api, output_api))
2521 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2513 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2522 input_api, output_api)) 2514 input_api, output_api))
2523 return results 2515 return results
OLDNEW
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698