Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2921853003: Don't display a settings button for extension notifications (Closed)

Created:
3 years, 6 months ago by Miguel Garcia
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't display a settings button for extension notifications BUG=676220 Review-Url: https://codereview.chromium.org/2921853003 Cr-Commit-Position: refs/heads/master@{#476741} Committed: https://chromium.googlesource.com/chromium/src/+/ba0a42d0d3c05a9b9e5b125436e29b4a114b115f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Miguel Garcia
3 years, 6 months ago (2017-06-02 14:54:08 UTC) #4
Tom Anderson
lgtm, just verified that the settings button is a no-op for extension notifications +peter for ...
3 years, 6 months ago (2017-06-02 18:48:45 UTC) #8
Miguel Garcia
On 2017/06/02 18:48:45, Tom Anderson wrote: > lgtm, just verified that the settings button is ...
3 years, 6 months ago (2017-06-02 18:51:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921853003/1
3 years, 6 months ago (2017-06-02 18:51:58 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:56:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba0a42d0d3c05a9b9e5b125436e2...

Powered by Google App Engine
This is Rietveld 408576698