Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_linux.cc

Issue 2921853003: Don't display a settings button for extension notifications (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_platform_bridge_linux.cc
diff --git a/chrome/browser/notifications/notification_platform_bridge_linux.cc b/chrome/browser/notifications/notification_platform_bridge_linux.cc
index 50dc9d50dcfbcf6e8ac96a2c8e86a971eec4c9bf..01d86ba993ec3547f91bbc64c4a9345b8c2c6dd8 100644
--- a/chrome/browser/notifications/notification_platform_bridge_linux.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_linux.cc
@@ -579,10 +579,12 @@ class NotificationPlatformBridgeLinuxImpl
actions.push_back(kDefaultButtonId);
actions.push_back("");
}
- // Always add a settings button.
- actions.push_back(kSettingsButtonId);
- actions.push_back(
- l10n_util::GetStringUTF8(IDS_NOTIFICATION_BUTTON_SETTINGS));
+ // Always add a settings button for web notifications.
+ if (notification_type != NotificationCommon::EXTENSION) {
+ actions.push_back(kSettingsButtonId);
+ actions.push_back(
+ l10n_util::GetStringUTF8(IDS_NOTIFICATION_BUTTON_SETTINGS));
+ }
}
writer.AppendArrayOfStrings(actions);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698