Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2921823002: Rationalize WakeLock naming conventions (Closed)

Created:
3 years, 6 months ago by juncai
Modified:
3 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, chfremer+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, mfoltz+watch_chromium.org, miu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, xjz+watch_chromium.org, creis+watch_chromium.org, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, haraken, David Trainor- moved to gerrit, Aaron Boodman, blink-reviews, pfeldman, darin (slow to review), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rationalize WakeLock naming conventions This CL makes some changes of the WakeLock naming conventions. WakeLockService -> WakeLock Drop the "Impl" from "WakeLockServiceImpl" BUG=701414 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2921823002 Cr-Commit-Position: refs/heads/master@{#477400} Committed: https://chromium.googlesource.com/chromium/src/+/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46

Patch Set 1 : rationalize WakeLock naming conventions #

Patch Set 2 : rebase #

Patch Set 3 : fix compile errors #

Patch Set 4 : rebase #

Patch Set 5 : fix browsertests #

Patch Set 6 : fix Mac compile error #

Total comments: 6

Patch Set 7 : address comments #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -939 lines) Patch
M chrome/browser/media/cast_transport_host_filter.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/cast_transport_host_filter.cc View 1 2 3 4 5 6 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 3 4 5 6 3 chunks +6 lines, -8 lines 0 comments Download
M content/browser/download/download_request_core.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -7 lines 0 comments Download
M content/browser/loader/wake_lock_resource_throttle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/wake_lock/wake_lock_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/webrtc/webrtc_internals.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/webrtc/webrtc_internals.cc View 1 2 3 4 5 6 2 chunks +6 lines, -7 lines 0 comments Download
M content/browser/webrtc/webrtc_internals_unittest.cc View 1 2 3 4 5 6 3 chunks +9 lines, -9 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M device/wake_lock/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M device/wake_lock/public/interfaces/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + device/wake_lock/public/interfaces/wake_lock.mojom View 2 chunks +8 lines, -8 lines 0 comments Download
M device/wake_lock/public/interfaces/wake_lock_context.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M device/wake_lock/public/interfaces/wake_lock_provider.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
D device/wake_lock/public/interfaces/wake_lock_service.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
A + device/wake_lock/wake_lock.h View 1 2 3 4 5 6 7 3 chunks +18 lines, -19 lines 0 comments Download
A + device/wake_lock/wake_lock.cc View 1 2 3 4 5 6 7 8 chunks +21 lines, -22 lines 0 comments Download
A + device/wake_lock/wake_lock_context.h View 3 chunks +11 lines, -12 lines 0 comments Download
A + device/wake_lock/wake_lock_context.cc View 1 2 chunks +12 lines, -13 lines 0 comments Download
A + device/wake_lock/wake_lock_for_testing.h View 1 2 3 4 5 6 7 2 chunks +11 lines, -11 lines 0 comments Download
A + device/wake_lock/wake_lock_for_testing.cc View 1 2 3 4 5 6 7 2 chunks +16 lines, -16 lines 0 comments Download
M device/wake_lock/wake_lock_provider.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -7 lines 0 comments Download
M device/wake_lock/wake_lock_provider.cc View 1 2 3 4 5 6 7 3 chunks +15 lines, -16 lines 0 comments Download
D device/wake_lock/wake_lock_service_context.h View 1 chunk +0 lines, -51 lines 0 comments Download
D device/wake_lock/wake_lock_service_context.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D device/wake_lock/wake_lock_service_impl.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -77 lines 0 comments Download
D device/wake_lock/wake_lock_service_impl.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -165 lines 0 comments Download
D device/wake_lock/wake_lock_service_impl_for_testing.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -47 lines 0 comments Download
D device/wake_lock/wake_lock_service_impl_for_testing.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -57 lines 0 comments Download
M services/device/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M services/device/device_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
D services/device/wake_lock/wake_lock_service_impl_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -205 lines 0 comments Download
A + services/device/wake_lock/wake_lock_unittest.cc View 1 2 3 4 5 6 7 10 chunks +30 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 1 2 3 4 5 6 2 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 49 (40 generated)
juncai
Please take a look.
3 years, 6 months ago (2017-06-03 00:39:30 UTC) #25
blundell
LGTM, thanks for doing this work! Much cleaner. Ke He, can you coordinate with Jun ...
3 years, 6 months ago (2017-06-05 11:48:11 UTC) #29
juncai
Ke He: What do you think of the order of landing this CL? Should I ...
3 years, 6 months ago (2017-06-05 18:58:25 UTC) #33
xhwang
media lgtm
3 years, 6 months ago (2017-06-05 20:08:18 UTC) #34
dgozman
lgtm
3 years, 6 months ago (2017-06-05 20:50:54 UTC) #35
dcheng
mojom naming changes rs lgtm
3 years, 6 months ago (2017-06-06 00:27:29 UTC) #38
ke.he
On 2017/06/05 18:58:25, juncai wrote: > Ke He: What do you think of the order ...
3 years, 6 months ago (2017-06-06 05:42:47 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921823002/140001
3 years, 6 months ago (2017-06-06 20:42:07 UTC) #46
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 20:48:34 UTC) #49
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8e8d6ec0bfba48ff738203afe3d2...

Powered by Google App Engine
This is Rietveld 408576698