Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3523)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2921823002: Rationalize WakeLock naming conventions (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 352d31e790138f201c6cd15bceaefed7293ed76f..5362c36dd2d6828b7ae8d78aa193d1c1ba286b90 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -604,13 +604,13 @@ void RenderFrameDevToolsAgentHost::OnClientAttached() {
frame_trace_recorder_.reset(new DevToolsFrameTraceRecorder());
#if defined(OS_ANDROID)
- GetWakeLockService()->RequestWakeLock();
+ GetWakeLock()->RequestWakeLock();
#endif
}
void RenderFrameDevToolsAgentHost::OnClientDetached() {
#if defined(OS_ANDROID)
- GetWakeLockService()->CancelWakeLock();
+ GetWakeLock()->CancelWakeLock();
#endif
frame_trace_recorder_.reset();
in_navigation_protocol_message_buffer_.clear();
@@ -826,12 +826,10 @@ bool RenderFrameDevToolsAgentHost::CheckConsistency() {
}
#if defined(OS_ANDROID)
-device::mojom::WakeLockService*
-RenderFrameDevToolsAgentHost::GetWakeLockService() {
+device::mojom::WakeLock* RenderFrameDevToolsAgentHost::GetWakeLock() {
// Here is a lazy binding, and will not reconnect after connection error.
if (!wake_lock_) {
- device::mojom::WakeLockServiceRequest request =
- mojo::MakeRequest(&wake_lock_);
+ device::mojom::WakeLockRequest request = mojo::MakeRequest(&wake_lock_);
device::mojom::WakeLockContext* wake_lock_context =
web_contents()->GetWakeLockContext();
if (wake_lock_context) {
@@ -914,13 +912,13 @@ void RenderFrameDevToolsAgentHost::DidDetachInterstitialPage() {
void RenderFrameDevToolsAgentHost::WasShown() {
#if defined(OS_ANDROID)
- GetWakeLockService()->RequestWakeLock();
+ GetWakeLock()->RequestWakeLock();
#endif
}
void RenderFrameDevToolsAgentHost::WasHidden() {
#if defined(OS_ANDROID)
- GetWakeLockService()->CancelWakeLock();
+ GetWakeLock()->CancelWakeLock();
#endif
}
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.h ('k') | content/browser/download/download_request_core.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698