Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2921793003: Increase SubresourceFcpOrder resource delay. (Closed)

Created:
3 years, 6 months ago by Bryan McQuade
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 NOTRY=true NOPRESUBMIT=true TBR=mattcary Review-Url: https://codereview.chromium.org/2918563002 Cr-Original-Commit-Position: refs/heads/master@{#475933} Review-Url: https://codereview.chromium.org/2921793003 Cr-Commit-Position: refs/branch-heads/3112@{#125} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2928419b78852575abb974d5426e356e75733efb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921793003/1
3 years, 6 months ago (2017-06-02 20:55:05 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 20:56:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2928419b78852575abb974d5426e...

Powered by Google App Engine
This is Rietveld 408576698