Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2918563002:
Increase SubresourceFcpOrder resource delay. (Closed)
|
Created:
3 years, 6 months ago by Bryan McQuade Modified:
3 years, 6 months ago CC:
chromium-reviews, mattcary Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIncrease SubresourceFcpOrder resource delay.
The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering
of FCP in page load metrics.
As part of addressing bug 726387 we'll add an additional 1s of buffering, which will
cause this test to fail.
We should break the prefetch predictor being affected by buffering altogether (bug
728156), but as a first step this change increases the timeout in the
SubresourceFcpOrder test so we can address bug 726387.
BUG=728176
TBR=lizeb
Review-Url: https://codereview.chromium.org/2918563002
Cr-Commit-Position: refs/heads/master@{#475933}
Committed: https://chromium.googlesource.com/chromium/src/+/1f326c6ec562cdbe58f9a958ca02758c620688d2
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 17 (12 generated)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Increase SubresourceFcpOrder resource delay. BUG= ========== to ========== Increase SubresourceFcpOrder resource delay. BUG=728176 ==========
Description was changed from ========== Increase SubresourceFcpOrder resource delay. BUG=728176 ========== to ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 ==========
bmcquade@chromium.org changed reviewers: + mattcary@chromium.org
bmcquade@chromium.org changed reviewers: + lizeb@chromium.org - mattcary@chromium.org
PTAL, thanks!
Description was changed from ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 ========== to ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 ==========
mattcary@chromium.org changed reviewers: + mattcary@chromium.org
lgtm LGTM, although obviously this is a short-term hack that we will fix as part of crbug.com/728156.
Description was changed from ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 ========== to ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 TBR=lizeb ==========
On 2017/05/31 at 15:19:27, mattcary wrote: > lgtm > > LGTM, although obviously this is a short-term hack that we will fix as part of crbug.com/728156. Thanks! lizeb, I TBR'd you since matt LGTM'd and this is blocking fixing of a different bug.
The CQ bit was checked by bmcquade@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496245180024160, "parent_rev":
"f9718e6fb6958916e4d0e947e1f202a2578d7ed6", "commit_rev":
"1f326c6ec562cdbe58f9a958ca02758c620688d2"}
Message was sent while issue was closed.
Description was changed from ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 TBR=lizeb ========== to ========== Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387. BUG=728176 TBR=lizeb Review-Url: https://codereview.chromium.org/2918563002 Cr-Commit-Position: refs/heads/master@{#475933} Committed: https://chromium.googlesource.com/chromium/src/+/1f326c6ec562cdbe58f9a958ca02... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1f326c6ec562cdbe58f9a958ca02... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
