Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2921793002: WebUI: Replace uglifyjs with uglify-es which understands ES6. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, tsergeant, calamity
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Replace uglifyjs with uglify-es which understands ES6. BUG=671426 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2921793002 Cr-Commit-Position: refs/heads/master@{#477492} Committed: https://chromium.googlesource.com/chromium/src/+/abde9ad7a7b06f7b50518fb8ea1caee9baaf2608

Patch Set 1 #

Patch Set 2 : Resolve conflits, reupload #

Patch Set 3 : Rename to PathToUglify #

Patch Set 4 : Resolve conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/vulcanize_gn.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/node/node_modules.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/node/node_modules.tar.gz.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/node/package.json View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (23 generated)
dpapad
3 years, 6 months ago (2017-06-06 21:19:54 UTC) #13
Dan Beam
lgtm
3 years, 6 months ago (2017-06-06 21:20:38 UTC) #15
michaelpg
lgtm!
3 years, 6 months ago (2017-06-06 23:35:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921793002/60001
3 years, 6 months ago (2017-06-07 00:48:32 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 00:52:26 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/abde9ad7a7b06f7b50518fb8ea1c...

Powered by Google App Engine
This is Rietveld 408576698