Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Issue 2920003002: Polymer: Update find_unused_elements.py (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: Update find_unused_elements.py - Stop assuming that Uglify is installed globally, instead use Uglify binary from third_party/node. - Remove obsolete logic to skip generated files. Generated files are no longer checked into the repository. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2920003002 Cr-Commit-Position: refs/heads/master@{#477694} Committed: https://chromium.googlesource.com/chromium/src/+/0638fc4291945fb6444537ad467da412e5d0711b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix script to actually work #

Total comments: 5

Patch Set 3 : Done #

Patch Set 4 : Rebase #

Total comments: 2

Patch Set 5 : Remove tempfile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/polymer/v1_0/find_unused_elements.py View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (8 generated)
dpapad
3 years, 6 months ago (2017-06-02 18:10:38 UTC) #3
dpapad
https://codereview.chromium.org/2920003002/diff/1/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (right): https://codereview.chromium.org/2920003002/diff/1/third_party/polymer/v1_0/find_unused_elements.py#newcode61 third_party/polymer/v1_0/find_unused_elements.py:61: proc = subprocess.Popen(['uglifyjs', filename], stdout=subprocess.PIPE) Actually there is more ...
3 years, 6 months ago (2017-06-02 18:19:26 UTC) #4
dpapad
Updated script. PTAL
3 years, 6 months ago (2017-06-02 19:01:26 UTC) #6
dpapad
https://codereview.chromium.org/2920003002/diff/1/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (right): https://codereview.chromium.org/2920003002/diff/1/third_party/polymer/v1_0/find_unused_elements.py#newcode61 third_party/polymer/v1_0/find_unused_elements.py:61: proc = subprocess.Popen(['uglifyjs', filename], stdout=subprocess.PIPE) On 2017/06/02 at 18:19:26, ...
3 years, 6 months ago (2017-06-02 19:01:54 UTC) #7
Dan Beam
https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (left): https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py#oldcode61 third_party/polymer/v1_0/find_unused_elements.py:61: proc = subprocess.Popen(['uglifyjs', filename], stdout=subprocess.PIPE) can we change to ...
3 years, 6 months ago (2017-06-02 21:49:08 UTC) #8
dpapad
https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (left): https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py#oldcode61 third_party/polymer/v1_0/find_unused_elements.py:61: proc = subprocess.Popen(['uglifyjs', filename], stdout=subprocess.PIPE) On 2017/06/02 at 21:49:08, ...
3 years, 6 months ago (2017-06-05 19:22:09 UTC) #9
michaelpg
https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (right): https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py#newcode19 third_party/polymer/v1_0/find_unused_elements.py:19: sys.path.append(os.path.join(_SRC_PATH, 'third_party', 'node')) remove uglify check in reproduce.sh
3 years, 6 months ago (2017-06-05 19:22:36 UTC) #11
dpapad
https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (right): https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py#newcode19 third_party/polymer/v1_0/find_unused_elements.py:19: sys.path.append(os.path.join(_SRC_PATH, 'third_party', 'node')) On 2017/06/05 at 19:22:36, michaelpg wrote: ...
3 years, 6 months ago (2017-06-05 19:42:02 UTC) #12
michaelpg
lgtm
3 years, 6 months ago (2017-06-05 19:50:43 UTC) #13
dpapad
PTAL https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (left): https://codereview.chromium.org/2920003002/diff/20001/third_party/polymer/v1_0/find_unused_elements.py#oldcode61 third_party/polymer/v1_0/find_unused_elements.py:61: proc = subprocess.Popen(['uglifyjs', filename], stdout=subprocess.PIPE) On 2017/06/02 at ...
3 years, 6 months ago (2017-06-06 21:39:55 UTC) #14
michaelpg
https://codereview.chromium.org/2920003002/diff/60001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (right): https://codereview.chromium.org/2920003002/diff/60001/third_party/polymer/v1_0/find_unused_elements.py#newcode15 third_party/polymer/v1_0/find_unused_elements.py:15: import tempfile remove
3 years, 6 months ago (2017-06-06 23:34:40 UTC) #15
dpapad
https://codereview.chromium.org/2920003002/diff/60001/third_party/polymer/v1_0/find_unused_elements.py File third_party/polymer/v1_0/find_unused_elements.py (right): https://codereview.chromium.org/2920003002/diff/60001/third_party/polymer/v1_0/find_unused_elements.py#newcode15 third_party/polymer/v1_0/find_unused_elements.py:15: import tempfile On 2017/06/06 at 23:34:40, michaelpg wrote: > ...
3 years, 6 months ago (2017-06-07 00:16:13 UTC) #16
Dan Beam
lgtm
3 years, 6 months ago (2017-06-07 06:08:05 UTC) #18
michaelpg
still lgtm
3 years, 6 months ago (2017-06-07 06:24:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920003002/80001
3 years, 6 months ago (2017-06-07 17:15:20 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 17:27:40 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0638fc4291945fb6444537ad467d...

Powered by Google App Engine
This is Rietveld 408576698