Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2921623006: [inspector] Inline InjectedScriptNative into InjectedScript (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Inline InjectedScriptNative into InjectedScript This is just a cleanup patch. BUG=none Review-Url: https://codereview.chromium.org/2921623006 Cr-Commit-Position: refs/heads/master@{#45669} Committed: https://chromium.googlesource.com/v8/v8/+/0a2e231716c86c8a6807eeb31ff1f370e7714708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -170 lines) Patch
M src/inspector/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/inspector/injected-script.h View 4 chunks +12 lines, -4 lines 0 comments Download
M src/inspector/injected-script.cc View 8 chunks +64 lines, -21 lines 0 comments Download
D src/inspector/injected-script-native.h View 1 chunk +0 lines, -46 lines 0 comments Download
D src/inspector/injected-script-native.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M src/inspector/inspector.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M src/inspector/v8-injected-script-host.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 6 months ago (2017-06-01 21:44:03 UTC) #4
kozy
this just lgtm
3 years, 6 months ago (2017-06-01 22:44:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921623006/1
3 years, 6 months ago (2017-06-02 00:27:20 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:28:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0a2e231716c86c8a6807eeb31ff1f370e77...

Powered by Google App Engine
This is Rietveld 408576698