Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2921523002: Clean up unused grit header includes in ui/. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, dcheng, mac-reviews_chromium.org, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up unused grit header includes in ui/. Review-Url: https://codereview.chromium.org/2921523002 Cr-Commit-Position: refs/heads/master@{#476189} Committed: https://chromium.googlesource.com/chromium/src/+/4657bd2e7747a72d7fab5b6fa19e770292fe3866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M ui/app_list/folder_image.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/all_apps_tile_item_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/cocoa/three_part_image_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/views/message_center_bubble.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/native_theme/common_theme.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/button_drag_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/blue_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/label_button_border.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/throbber.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/examples/button_example.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/style/platform_style.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
Created with assistance from tools/resources/list_unused_grit_header.py.
3 years, 6 months ago (2017-06-01 01:14:21 UTC) #6
sky
LGTM
3 years, 6 months ago (2017-06-01 02:02:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921523002/1
3 years, 6 months ago (2017-06-01 04:20:01 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 04:24:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4657bd2e7747a72d7fab5b6fa19e...

Powered by Google App Engine
This is Rietveld 408576698