Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2921473002: [Extensions] Remove the extension_action_redesign switch (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove the extension_action_redesign switch Remove the final use of the extension_action_redesign switch in the extension action manifest handler, and remove the switch itself. BUG=590321 Review-Url: https://codereview.chromium.org/2921473002 Cr-Commit-Position: refs/heads/master@{#476662} Committed: https://chromium.googlesource.com/chromium/src/+/9e7b7c2e654e4764bdf3591437bc81efdea578cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/common/extensions/manifest_handlers/extension_action_handler.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/common/feature_switch.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/feature_switch.cc View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Devlin
3 years, 6 months ago (2017-05-31 21:46:56 UTC) #4
Finnur
LGTM. Congratulations! :)
3 years, 6 months ago (2017-06-02 11:12:17 UTC) #7
Devlin
On 2017/06/02 11:12:17, Finnur wrote: > LGTM. > > Congratulations! :) Heh long overdue cleanup ...
3 years, 6 months ago (2017-06-02 14:35:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921473002/1
3 years, 6 months ago (2017-06-02 14:36:06 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:26:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e7b7c2e654e4764bdf3591437bc...

Powered by Google App Engine
This is Rietveld 408576698