Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5146)

Unified Diff: chrome/common/extensions/manifest_handlers/extension_action_handler.cc

Issue 2921473002: [Extensions] Remove the extension_action_redesign switch (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/feature_switch.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_handlers/extension_action_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/extension_action_handler.cc b/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
index 9cb174cf0b095628c661c570e4aee0b7ea091e49..923e1040419f05b81e6cff920c41249e58d66bbc 100644
--- a/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
@@ -13,7 +13,6 @@
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/grit/generated_resources.h"
#include "extensions/common/extension.h"
-#include "extensions/common/feature_switch.h"
#include "extensions/common/file_util.h"
#include "extensions/common/manifest_constants.h"
@@ -61,8 +60,6 @@ bool ExtensionActionHandler::Parse(Extension* extension,
else
ActionInfo::SetBrowserActionInfo(extension, action_info.release());
} else { // No key, used for synthesizing an action for extensions with none.
- if (!FeatureSwitch::extension_action_redesign()->IsEnabled())
- return true; // Do nothing if the switch is off.
if (Manifest::IsComponentLocation(extension->location()))
return true; // Don't synthesize actions for component extensions.
if (extension->was_installed_by_default())
« no previous file with comments | « no previous file | extensions/common/feature_switch.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698