Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc
index 1095c5d031e2184f1a61f7bee6e28906fbbebbd1..8e35f24b09ccd9360750f355436cdd33db890707 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc
@@ -67,8 +67,8 @@ TEST_F(NGOutOfFlowLayoutPartTest, FixedInsideAbs) {
LayoutNGBlockFlow* block_flow = ToLayoutNGBlockFlow(rel->GetLayoutObject());
RefPtr<NGConstraintSpace> space =
NGConstraintSpace::CreateFromLayoutObject(*block_flow);
- NGBlockNode* node = new NGBlockNode(block_flow);
- RefPtr<NGLayoutResult> result = node->Layout(space.Get());
+ NGBlockNode node(block_flow);
+ RefPtr<NGLayoutResult> result = node.Layout(space.Get());
EXPECT_EQ(result->OutOfFlowDescendants().size(), (size_t)2);
// Test the final result.
@@ -105,12 +105,12 @@ TEST_F(NGOutOfFlowLayoutPartTest, OrthogonalWritingMode1) {
LayoutNGBlockFlow* block_flow =
ToLayoutNGBlockFlow(GetLayoutObjectByElementId("container"));
- auto* node = new NGBlockNode(block_flow);
+ NGBlockNode node(block_flow);
RefPtr<NGConstraintSpace> space =
NGConstraintSpace::CreateFromLayoutObject(*block_flow);
RefPtr<const NGPhysicalFragment> fragment =
- node->Layout(space.Get())->PhysicalFragment();
+ node.Layout(space.Get())->PhysicalFragment();
EXPECT_EQ(NGPhysicalSize(LayoutUnit(200), LayoutUnit(400)), fragment->Size());
fragment = ToNGPhysicalBoxFragment(fragment.Get())->Children()[0];
@@ -144,12 +144,12 @@ TEST_F(NGOutOfFlowLayoutPartTest, OrthogonalWritingMode2) {
LayoutNGBlockFlow* block_flow =
ToLayoutNGBlockFlow(GetLayoutObjectByElementId("container"));
- auto* node = new NGBlockNode(block_flow);
+ NGBlockNode node(block_flow);
RefPtr<NGConstraintSpace> space =
NGConstraintSpace::CreateFromLayoutObject(*block_flow);
RefPtr<const NGPhysicalFragment> fragment =
- node->Layout(space.Get())->PhysicalFragment();
+ node.Layout(space.Get())->PhysicalFragment();
EXPECT_EQ(NGPhysicalSize(LayoutUnit(200), LayoutUnit(400)), fragment->Size());
fragment = ToNGPhysicalBoxFragment(fragment.Get())->Children()[0];

Powered by Google App Engine
This is Rietveld 408576698