third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc - Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)

Patch Set: new ng-bot expectations Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc

index ad76fa3441d32ede7d16d5b678bb6272ef3ae3be..db65ad4367f38cb453bbcf49f91a3fad71d45f76 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc

@@ -25,11 +25,11 @@ TEST_F(NGSpaceUtilsTest, NewFormattingContextForOutOfFlowChild) {

auto& parent_style = GetLayoutObjectByElementId("parent")->StyleRef();

auto* child = GetLayoutObjectByElementId("child");

- auto* node = new NGBlockNode(child);

+ NGBlockNode node(ToLayoutBox(child));

auto run_test = [&](RefPtr<ComputedStyle> style) {

child->SetStyle(style);

- EXPECT_TRUE(IsNewFormattingContextForBlockLevelChild(parent_style, *node));

+ EXPECT_TRUE(IsNewFormattingContextForBlockLevelChild(parent_style, node));

};

RefPtr<ComputedStyle> style = ComputedStyle::Create();