Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
index aa7494ec9da0ea96f15bd75f36e58fee2c976ccd..c42696b5954dd688d7696b2f3833950e65d6fcfe 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
@@ -65,7 +65,7 @@ NGOutOfFlowLayoutPart::NGOutOfFlowLayoutPart(
}
void NGOutOfFlowLayoutPart::Run() {
- PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>> out_of_flow_candidates;
+ Vector<NGBlockNode> out_of_flow_candidates;
Vector<NGStaticPosition> out_of_flow_candidate_positions;
container_builder_->GetAndClearOutOfFlowDescendantCandidates(
&out_of_flow_candidates, &out_of_flow_candidate_positions);
@@ -78,10 +78,10 @@ void NGOutOfFlowLayoutPart::Run() {
out_of_flow_candidate_positions[position_index++];
if (IsContainingBlockForAbsoluteDescendant(container_style_,
- descendant->Style())) {
+ descendant.Style())) {
NGLogicalOffset offset;
RefPtr<NGLayoutResult> result =
- LayoutDescendant(*descendant, static_position, &offset);
+ LayoutDescendant(descendant, static_position, &offset);
// TODO(atotic) Need to adjust size of overflow rect per spec.
container_builder_->AddChild(std::move(result), offset);
} else {
@@ -98,7 +98,7 @@ void NGOutOfFlowLayoutPart::Run() {
}
RefPtr<NGLayoutResult> NGOutOfFlowLayoutPart::LayoutDescendant(
- NGBlockNode& descendant,
+ NGBlockNode descendant,
NGStaticPosition static_position,
NGLogicalOffset* offset) {
// Adjust the static_position origin. The static_position coordinate origin is
@@ -162,7 +162,7 @@ RefPtr<NGLayoutResult> NGOutOfFlowLayoutPart::LayoutDescendant(
// 2. To compute final fragment, when block size is known from the absolute
// position calculation.
RefPtr<NGLayoutResult> NGOutOfFlowLayoutPart::GenerateFragment(
- NGBlockNode& descendant,
+ NGBlockNode descendant,
const Optional<LayoutUnit>& block_estimate,
const NGAbsolutePhysicalPosition node_position) {
// As the block_estimate is always in the descendant's writing mode, we build

Powered by Google App Engine
This is Rietveld 408576698