Issue 292123005: Add a few words to cjdict.txt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292123005: Add a few words to cjdict.txt (Closed)

Created:
6 years, 7 months ago by jungshik at Google

Modified:
6 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Visibility:
Public.

More Reviews

Description

Add a few words to cjdict.txt and remove an unintended change in line.txt When the upstream took our patches for CJ segmentation, over 10k words were dropped. Some of them are pretty common and not having them led to a Blink layout test failure. Add several of them back to cjdict.txt. In addition, remove a patch that breaks line breaking around single/double quotation marks. Rebuild the data for Linux/Mac/Windows/Android. BUG=132145 TEST=Once rolled, layouttest:fast/text/international/cjk-segmentation.html and fast/hyphen-min-preferred-width.html pass. TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272650

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+978 lines, -1287 lines)			Patch
M	README.chromium	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	android/icudtl.dat	View	1	Binary file		0 comments	Download
M	android/icudtl_dat.S	View		3 chunks	+924 lines, -948 lines	0 comments	Download
M	patches/brkitr.patch	View	1	3 chunks	+35 lines, -330 lines	0 comments	Download
M	scripts/accept_lang.list	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	source/data/brkitr/cjdict.txt	View		4 chunks	+7 lines, -0 lines	0 comments	Download
M	source/data/brkitr/line.txt	View	1	3 chunks	+3 lines, -7 lines	0 comments	Download
M	source/data/in/icudtl.dat	View	1	Binary file		0 comments	Download
M	windows/icudt.dll	View		Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

Committed patchset #2 manually as r272650 (presubmit successful).

6 years, 7 months ago (2014-05-24 00:18:50 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages