Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: tools/grit/grit_rule.gni

Issue 2921143002: Reverse accidental enabling of 'use strict' in closure compiler (Closed)
Patch Set: emit_use_strict=false Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/grit/grit_rule.gni
diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni
index 3db7a6c6b210ceb8826faaef6ae3535efb26e601..ca524b6e287df5fb9b18add95f39fa8bb2181565 100644
--- a/tools/grit/grit_rule.gni
+++ b/tools/grit/grit_rule.gni
@@ -402,7 +402,10 @@ template("grit") {
"--js-minifier",
js_minifier_command,
]
- inputs += [ _js_minifier ]
+ inputs += [
+ _js_minifier,
+ "//third_party/closure_compiler/compiler/compiler.jar",
flackr 2017/06/05 17:39:46 I'm not sure I follow this change, is this invalid
wychen 2017/06/05 17:46:25 The dependency was underspecified, so that when cl
flackr 2017/06/05 17:54:54 Ah I see, this makes sense to do as a separate com
wychen 2017/06/05 18:25:56 I'll create a separate CL. What do you mean by arg
flackr 2017/06/05 18:46:40 Ah okay, as long as argument changes in closure_ar
wychen 2017/06/05 19:05:43 Split out here: https://codereview.chromium.org/29
+ ]
}
# Must be after the args are computed since they are re-used.

Powered by Google App Engine
This is Rietveld 408576698