Reverse accidental enabling of 'use strict' in closure compiler

tools/grit/grit_rule.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Instantiate grit. This will produce a script target to run grit, and a
 # static library that compiles the .cc files.
 #
 # Parameters
 #
 #   source (required)
@@ skipping 384 matching lines @@
       js_minifier_command = "$js_minifier_command --closure_args"
       foreach(closure_arg,
               common_closure_args + minifying_closure_args +
                   default_disabled_closure_args) {
         js_minifier_command = "$js_minifier_command $closure_arg"
       }
       args += [
         "--js-minifier",
         js_minifier_command,
       ]
-      inputs += [ _js_minifier ]
+      inputs += [
+        _js_minifier,
+        "//third_party/closure_compiler/compiler/compiler.jar",

[flackr, 2017/06/05 17:39:46]

I'm not sure I follow this change, is this invalidating compiled resources on
the compiler changing? Does the compiler change when you change the arguments
set in closure_arguments.gni?

[wychen, 2017/06/05 17:46:25]

The dependency was underspecified, so that when closure rolled in, the CQ and
waterfall didn't reliably repack the resources, and made bisecting difficult for
crbug.com/728655.

[flackr, 2017/06/05 17:54:54]

Ah I see, this makes sense to do as a separate commit. You may also want to
depend on the arguments file right?

[wychen, 2017/06/05 18:25:56]

I'll create a separate CL.
What do you mean by argument file? It looks like this js minifier use command
line arguments, and I think it'll get rebuilt if the arguments change.

There are several python scripts that's underspecified as well. Not sure if it
makes sense to add them all.

[flackr, 2017/06/05 18:46:40]

Ah okay, as long as argument changes in closure_args.gni trigger a rebuild then
it should be fine. I'm not sure, about adding other dependencies, I would stick
to just the ones which are known to be problematic.

[wychen, 2017/06/05 19:05:43]

Split out here:
https://codereview.chromium.org/2924653002/

+      ]
     }
 
     # Must be after the args are computed since they are re-used.
     # See the comments for the two variables used in this condition for
     # why this works this way.
     if (compute_grit_inputs_for_analyze && !source_is_generated) {
       grit_info_script = "//tools/grit/grit_info.py"
       grit_info_args = [
                          "--inputs",
                          source_path,
@@ skipping 55 matching lines @@
     if (defined(invoker.configs)) {
       configs += invoker.configs
     }
 
     if (defined(invoker.visibility)) {
       visibility = invoker.visibility
     }
     output_name = grit_output_name
   }
 }