Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2921003002: Replace lint suppressions for vector drawables with targetApi attribute (Closed)

Created:
3 years, 6 months ago by bsazonov
Modified:
3 years, 6 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace lint suppressions for vector drawables with targetApi attribute Vector drawables without targetApi attribute cause lint error when target API is less than 21. BUG=635567 Review-Url: https://codereview.chromium.org/2921003002 Cr-Commit-Position: refs/heads/master@{#476717} Committed: https://chromium.googlesource.com/chromium/src/+/3e4b2fc9ce4b811de3ecb35ed1bb4989c39b1ad4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java/res/drawable/downloads_big.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_bluetooth_connected.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_signal_cellular_1_bar.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_signal_cellular_2_bar.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_signal_cellular_3_bar.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_signal_cellular_4_bar.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bsazonov
Mike, please review changes in build/android/lint/suppressions.xml. Theresa, please review changes in chrome/android/java/res/drawable/. This CL is ...
3 years, 6 months ago (2017-06-02 14:39:32 UTC) #4
Theresa
lgtm
3 years, 6 months ago (2017-06-02 15:04:57 UTC) #5
mikecase (-- gone --)
lgtm
3 years, 6 months ago (2017-06-02 15:53:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921003002/1
3 years, 6 months ago (2017-06-02 17:56:02 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:01:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e4b2fc9ce4b811de3ecb35ed1bb...

Powered by Google App Engine
This is Rietveld 408576698