Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2912083003: Replace assets for avatar placeholder on Android (Closed)
Patch Set: Use vector asset for account avatar picture Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 </issue> 189 </issue>
190 <issue id="NewApi"> 190 <issue id="NewApi">
191 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/> 191 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
192 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml"/> 192 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml"/>
193 <ignore regexp="chrome/android/java/res/drawable/ic_bluetooth_connected.xml" /> 193 <ignore regexp="chrome/android/java/res/drawable/ic_bluetooth_connected.xml" />
194 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xm l" /> 194 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xm l" />
195 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_1_bar.xm l" /> 195 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_1_bar.xm l" />
196 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_2_bar.xm l" /> 196 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_2_bar.xm l" />
197 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_3_bar.xm l" /> 197 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_3_bar.xm l" />
198 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_4_bar.xm l" /> 198 <ignore regexp="chrome/android/java/res/drawable/ic_signal_cellular_4_bar.xm l" />
199 <ignore regexp="chrome/android/java/res/drawable/logo_avatar_anonymous.xml"/ >
Theresa 2017/06/01 23:22:15 optional nit: Instead of adding an ingnore here, y
bsazonov 2017/06/02 13:17:20 Didn't know about this option, thanks! I totally a
199 <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/> 200 <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
200 <ignore regexp="chromecast/internal"/> 201 <ignore regexp="chromecast/internal"/>
201 <ignore regexp="com/android/tv"/> 202 <ignore regexp="com/android/tv"/>
202 <ignore regexp="com/android/webview/chromium/ServiceWorkerControllerAdapter. class"/> 203 <ignore regexp="com/android/webview/chromium/ServiceWorkerControllerAdapter. class"/>
203 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/> 204 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/>
204 <ignore regexp="com/android/webview/chromium/WebViewChromium.class"/> 205 <ignore regexp="com/android/webview/chromium/WebViewChromium.class"/>
205 <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider. class"/> 206 <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider. class"/>
206 <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" /> 207 <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" />
207 <ignore regexp="com/google/android/apps/cast"/> 208 <ignore regexp="com/google/android/apps/cast"/>
208 <ignore regexp="com/google/android/apps/mediashell"/> 209 <ignore regexp="com/google/android/apps/mediashell"/>
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 <ignore regexp="chrome/android/javatests"/> 463 <ignore regexp="chrome/android/javatests"/>
463 <ignore regexp="/test/"/> 464 <ignore regexp="/test/"/>
464 </issue> 465 </issue>
465 <issue id="WrongCall" severity="ignore"/> 466 <issue id="WrongCall" severity="ignore"/>
466 <issue id="WrongConstant"> 467 <issue id="WrongConstant">
467 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorDialog.java"/> 469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorDialog.java"/>
469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 470 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
470 </issue> 471 </issue>
471 </lint> 472 </lint>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698