Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2920943002: Remove superfluous diff code in ComputedStyle::UpdatePropertySpecificDifferences (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
shend
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove superfluous diff code in ComputedStyle::UpdatePropertySpecificDifferences This code was generated in https://codereview.chromium.org/2897193005 and the generated function is being called too. I seem to have forgotten to remove the handwritten code. The diff of the generated code is here: https://gist.github.com/7db928ec119076f5526f3f6d2117d407/revisions BUG=710938 Review-Url: https://codereview.chromium.org/2920943002 Cr-Commit-Position: refs/heads/master@{#476603} Committed: https://chromium.googlesource.com/chromium/src/+/e6cbdad3d4c498263f2ab30a2e193e3a634afb02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +0 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
nainar
shend@, PTAL? Thanks!
3 years, 6 months ago (2017-06-02 05:43:43 UTC) #4
shend
lgtm
3 years, 6 months ago (2017-06-02 08:34:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920943002/1
3 years, 6 months ago (2017-06-02 08:34:31 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 08:38:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6cbdad3d4c498263f2ab30a2e19...

Powered by Google App Engine
This is Rietveld 408576698