Remove references to rare_inherited_data_ in ComputedStyle.

Remove references to rare_inherited_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to rare_inherited_data_ in
ComputedStyle, replacing with generated or handwritten getters.

This patch also edits a callsite of 
ComputedStyle::SetTextOrientation to make it uniform with other 
setters in ComputedStyle.

BUG=710938
Review-Url: https://codereview.chromium.org/2918983002
Cr-Commit-Position: refs/heads/master@{#476943}
Committed: https://chromium.googlesource.com/chromium/src/+/7f9edaaa091bddbff260234e49b6c2988720c5a6

[nainar, 2017-06-02 07:48:53]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 07:49:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-06-02 08:38:56]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 08:39:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-06-02 08:39:53]

Description was changed from

==========
Remove references to rare_inherited_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to rare_inherited_data_ in
ComputedStyle, replacing with generated or handwritten getters.

BUG=710938
==========

to

==========
Remove references to rare_inherited_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to rare_inherited_data_ in
ComputedStyle, replacing with generated or handwritten getters.

This patch also edits a callsite of 
ComputedStyle::SetTextOrientation to make it uniform with other 
setters in ComputedStyle.

BUG=710938
==========

[nainar, 2017-06-02 08:40:29]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-06-02 08:40:30]

shend@ , 

PTAL? (On Monday! :P)

Thanks!

[commit-bot: I haz the power, 2017-06-02 10:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 10:20:53]

Dry run: This issue passed the CQ dry run.

[shend, 2017-06-05 00:25:36]

lgtm

[nainar, 2017-06-05 03:12:32]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-06-05 03:12:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 05:05:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496632352193490,
"parent_rev": "55f9320b2d675e4b008597fd269d102e1d4d3b00", "commit_rev":
"7f9edaaa091bddbff260234e49b6c2988720c5a6"}

[commit-bot: I haz the power, 2017-06-05 05:05:27]

Description was changed from

==========
Remove references to rare_inherited_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to rare_inherited_data_ in
ComputedStyle, replacing with generated or handwritten getters.

This patch also edits a callsite of 
ComputedStyle::SetTextOrientation to make it uniform with other 
setters in ComputedStyle.

BUG=710938
==========

to

==========
Remove references to rare_inherited_data_ in ComputedStyle.

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to rare_inherited_data_ in
ComputedStyle, replacing with generated or handwritten getters.

This patch also edits a callsite of 
ComputedStyle::SetTextOrientation to make it uniform with other 
setters in ComputedStyle.

BUG=710938

Review-Url: https://codereview.chromium.org/2918983002
Cr-Commit-Position: refs/heads/master@{#476943}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f9edaaa091bddbff260234e49b6...
==========

[commit-bot: I haz the power, 2017-06-05 05:05:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f9edaaa091bddbff260234e49b6...