Rename TextMatchMarker::rendered_rect_ to layout_rect_

Rename TextMatchMarker::rendered_rect_ to layout_rect_

Rename TextMatchMarker::rendered_rect_ to layout_rect_ and TextMatchMarker
methods with "RenderedRect" in name to instead use "LayoutRect". LayoutRect is a
more specific name than RenderedRect (layout is one step in the rendering
pipeline).

BUG=707867
Review-Url: https://codereview.chromium.org/2920913003
Cr-Commit-Position: refs/heads/master@{#477008}
Committed: https://chromium.googlesource.com/chromium/src/+/9187085c7cdff3a2864af92f566d7afacbb3060c

[rlanday, 2017-06-02 20:21:28]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-02 20:22:02]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-06-02 20:22:02]

Note: NullifyRenderedRect() is currently unused, should we just remove it?

[commit-bot: I haz the power, 2017-06-02 20:22:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:16:21]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-03 02:31:35]

lgtm

LayoutStatus::ValidNull is also unused. I think we should remove both of them.

Do you also plan to rename DMC functions related to rendered rect?

[rlanday, 2017-06-03 14:43:41]

On 2017/06/03 at 02:31:35, xiaochengh wrote:
> lgtm
> 
> LayoutStatus::ValidNull is also unused. I think we should remove both of them.
> 
> Do you also plan to rename DMC functions related to rendered rect?

Oh yeah, we should rename DMC::RenderedRectsForTextMatchMarkers() (I think
that's the only one)

[rlanday, 2017-06-04 23:26:27]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 23:26:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-04 23:26:55]

On 2017/06/03 at 14:43:41, rlanday wrote:
> On 2017/06/03 at 02:31:35, xiaochengh wrote:
> > lgtm
> > 
> > LayoutStatus::ValidNull is also unused. I think we should remove both of
them.
> > 
> > Do you also plan to rename DMC functions related to rendered rect?
> 
> Oh yeah, we should rename DMC::RenderedRectsForTextMatchMarkers() (I think
that's the only one)

Updated

[commit-bot: I haz the power, 2017-06-05 01:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 01:00:46]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-05 02:06:54]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-06-05 02:06:55]

lgtm

+tkent@ for core/frames/

[tkent, 2017-06-05 02:14:42]

lgtm, however returning Vector<IntRect> thought the function name starts with
"LayoutRects" might be confusing.

[rlanday, 2017-06-05 17:12:14]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-05 17:12:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2920913003/#ps20001
(title: "Rename DMC::RenderedRectsForTextMatchMarkers()")

[commit-bot: I haz the power, 2017-06-05 17:12:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 17:16:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496682734054430,
"parent_rev": "1c0ac28d4278906bdcbe0492bfa34ca55e6e1e8a", "commit_rev":
"9187085c7cdff3a2864af92f566d7afacbb3060c"}

[commit-bot: I haz the power, 2017-06-05 17:17:11]

Description was changed from

==========
Rename TextMatchMarker::rendered_rect_ to layout_rect_

Rename TextMatchMarker::rendered_rect_ to layout_rect_ and TextMatchMarker
methods with "RenderedRect" in name to instead use "LayoutRect". LayoutRect is a
more specific name than RenderedRect (layout is one step in the rendering
pipeline).

BUG=707867
==========

to

==========
Rename TextMatchMarker::rendered_rect_ to layout_rect_

Rename TextMatchMarker::rendered_rect_ to layout_rect_ and TextMatchMarker
methods with "RenderedRect" in name to instead use "LayoutRect". LayoutRect is a
more specific name than RenderedRect (layout is one step in the rendering
pipeline).

BUG=707867

Review-Url: https://codereview.chromium.org/2920913003
Cr-Commit-Position: refs/heads/master@{#477008}
Committed:
https://chromium.googlesource.com/chromium/src/+/9187085c7cdff3a2864af92f566d...
==========

[commit-bot: I haz the power, 2017-06-05 17:17:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9187085c7cdff3a2864af92f566d...