Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2920883002: chromeos: Make ash system tray directly observe IME state changes (Closed)

Created:
3 years, 6 months ago by James Cook
Modified:
3 years, 6 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org, Hadi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Make ash system tray directly observe IME state changes For mustash we're eliminating places where chrome code calls directly into ash, because they will eventually run in different processes. Remove IME observers from SystemTrayDelegateChromeOS and add them to ash TrayIME and ImeTrayMenu. This allows SystemTrayNotifier to be simplified and the ash IMEObserver to be removed. Fix some tests that were not initializing the singleton returned by InputMethodManager::Get(). BUG=724305 TEST=ash_unittests, chrome unit_tests, manually use system tray IME menu and shelf IME menu

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -163 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ash/system/ime/ime_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos.h View 4 chunks +28 lines, -8 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 4 chunks +38 lines, -6 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.h View 3 chunks +28 lines, -9 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 5 chunks +36 lines, -6 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray_unittest.cc View 13 chunks +14 lines, -16 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 3 chunks +0 lines, -8 lines 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 4 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 6 chunks +0 lines, -34 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
James Cook
azurewei, please take a look.
3 years, 6 months ago (2017-06-01 21:19:31 UTC) #4
James Cook
+cc Hadi just FYI
3 years, 6 months ago (2017-06-01 22:49:45 UTC) #5
James Cook
azurewei, please don't review this yet. I might need to take a different approach.
3 years, 6 months ago (2017-06-02 16:27:13 UTC) #8
James Cook
3 years, 6 months ago (2017-06-05 15:34:49 UTC) #9
Abandoned. I'm going to take a different approach, using mojo.

Powered by Google App Engine
This is Rietveld 408576698