Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/ui/ash/system_tray_delegate_chromeos.h

Issue 2920883002: chromeos: Make ash system tray directly observe IME state changes (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/system_tray_delegate_chromeos.h
diff --git a/chrome/browser/ui/ash/system_tray_delegate_chromeos.h b/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
index 34ba99c6dcbd2b69708dc746d4573d3aa6f0072b..e88a2bad321b9688542c0f27a286c6967684a73a 100644
--- a/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
+++ b/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
@@ -23,8 +23,6 @@
#include "content/public/browser/notification_registrar.h"
#include "extensions/browser/app_window/app_window_registry.h"
#include "ui/base/ime/chromeos/ime_keyboard.h"
-#include "ui/base/ime/chromeos/input_method_manager.h"
-#include "ui/chromeos/ime/input_method_menu_manager.h"
namespace ash {
class SystemTrayNotifier;
@@ -32,15 +30,11 @@ class SystemTrayNotifier;
namespace chromeos {
-// TODO(jamescook): Move observation of IME state into ash.
class SystemTrayDelegateChromeOS
- : public ui::ime::InputMethodMenuManager::Observer,
- public ash::SystemTrayDelegate,
+ : public ash::SystemTrayDelegate,
public content::NotificationObserver,
- public input_method::InputMethodManager::Observer,
public chrome::BrowserListObserver,
- public extensions::AppWindowRegistry::Observer,
- public input_method::InputMethodManager::ImeMenuObserver {
+ public extensions::AppWindowRegistry::Observer {
public:
SystemTrayDelegateChromeOS();
~SystemTrayDelegateChromeOS() override;
@@ -87,15 +81,6 @@ class SystemTrayDelegateChromeOS
void UpdatePerformanceTracing();
- // Overridden from InputMethodManager::Observer.
- void InputMethodChanged(input_method::InputMethodManager* manager,
- Profile* profile,
- bool show_message) override;
-
- // Overridden from InputMethodMenuManager::Observer.
- void InputMethodMenuItemChanged(
- ui::ime::InputMethodMenuManager* manager) override;
-
// Overridden from chrome::BrowserListObserver:
void OnBrowserRemoved(Browser* browser) override;
@@ -105,14 +90,6 @@ class SystemTrayDelegateChromeOS
void OnAccessibilityStatusChanged(
const AccessibilityStatusEventDetails& details);
- // input_method::InputMethodManager::ImeMenuObserver:
- void ImeMenuActivationChanged(bool is_active) override;
- void ImeMenuListChanged() override;
- void ImeMenuItemsChanged(
- const std::string& engine_id,
- const std::vector<input_method::InputMethodManager::MenuItem>& items)
- override;
-
std::unique_ptr<content::NotificationRegistrar> registrar_;
std::unique_ptr<PrefChangeRegistrar> local_state_registrar_;
std::unique_ptr<PrefChangeRegistrar> user_pref_registrar_;

Powered by Google App Engine
This is Rietveld 408576698