Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 2917683003: chromeos: Remove the last IME methods from ash::SystemTrayDelegate (Closed)

Created:
3 years, 6 months ago by James Cook
Modified:
3 years, 6 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews, kalyank, sadrul, Hadi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove the last IME methods from ash::SystemTrayDelegate For mustash the code in ash will run in its own process. We are eliminating ash to chrome delegate methods. Move the remaining IME methods out of SystemTrayDelegateChromeOS into utility functions in ash::ime_util. Those functions can call into //ui/base/ime/chromeos directly. BUG=724305 TEST=ash_unittests, manually test IME shelf menu and system tray menu

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -142 lines) Patch
M ash/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ash/system/ime/ime_util.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A ash/system/ime/ime_util.cc View 1 1 chunk +111 lines, -0 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 1 3 chunks +5 lines, -9 lines 0 comments Download
M ash/system/ime/tray_ime_chromeos_unittest.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M ash/system/ime_menu/ime_list_view.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray_unittest.cc View 1 6 chunks +25 lines, -8 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 3 chunks +0 lines, -17 lines 0 comments Download
M ash/system/tray/system_tray_delegate.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M ash/test/test_system_tray_delegate.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M ash/test/test_system_tray_delegate.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 4 chunks +0 lines, -55 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
James Cook
azurewei, please take a look.
3 years, 6 months ago (2017-06-01 16:45:57 UTC) #6
James Cook
+cc Hadi just FYI
3 years, 6 months ago (2017-06-01 22:49:19 UTC) #9
James Cook
azurewei, please don't review this yet. I might need to take a different approach.
3 years, 6 months ago (2017-06-02 16:27:22 UTC) #10
Azure Wei
On 2017/06/02 16:27:22, James Cook wrote: > azurewei, please don't review this yet. I might ...
3 years, 6 months ago (2017-06-05 06:29:47 UTC) #11
James Cook
3 years, 6 months ago (2017-06-05 15:35:11 UTC) #12
Abandoned. I'm going to take a different approach, using mojo.

Powered by Google App Engine
This is Rietveld 408576698