Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Issue 2920683002: Move the check icon of menu to the right (Closed)

Created:
3 years, 6 months ago by Marti Wong
Modified:
3 years, 6 months ago
Reviewers:
dominickn, Theresa
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Move the check icon of menu to the right screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view BUG=725784 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2901913003 Cr-Original-Commit-Position: refs/heads/master@{#475738} Review-Url: https://codereview.chromium.org/2920683002 Cr-Commit-Position: refs/branch-heads/3112@{#79} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2bf0d4cb540c87db055985707321a300a2694f25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/android/java/res/layout/translate_menu_item_checked.xml View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Marti Wong
Hi Dominick, PTAL. thx~! Merging the CL to M60 (3112).
3 years, 6 months ago (2017-06-01 04:30:31 UTC) #2
dominickn
lgtm
3 years, 6 months ago (2017-06-01 04:35:23 UTC) #3
Marti Wong
On 2017/06/01 04:35:23, dominickn wrote: > lgtm thx!
3 years, 6 months ago (2017-06-01 04:45:17 UTC) #4
Marti Wong
Hi Theresa, PTAL. merging to M60 (3112) need owner's LGTM
3 years, 6 months ago (2017-06-01 04:46:52 UTC) #6
dominickn
For a merge, you don't need owner's approval. Just add NOTRY=true and NOPRESUBMIT=true to the ...
3 years, 6 months ago (2017-06-01 04:58:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920683002/1
3 years, 6 months ago (2017-06-01 05:00:12 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-01 05:00:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920683002/1
3 years, 6 months ago (2017-06-01 05:01:01 UTC) #14
Marti Wong
Thanks Dominick for the tip!
3 years, 6 months ago (2017-06-01 05:01:26 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 05:01:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bf0d4cb540c87db055985707321...

Powered by Google App Engine
This is Rietveld 408576698