Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2901913003:
Move the check icon of menu to the right (Closed)
|
Created:
3 years, 7 months ago by Marti Wong Modified:
3 years, 6 months ago CC:
chromium-reviews, agrieve+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove the check icon of menu to the right
screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view
BUG=725784
Review-Url: https://codereview.chromium.org/2901913003
Cr-Commit-Position: refs/heads/master@{#475738}
Committed: https://chromium.googlesource.com/chromium/src/+/394848886c74b46a456a5eec488a9866b8f86b54
Patch Set 1 #
Total comments: 3
Patch Set 2 : sync & merge #Messages
Total messages: 26 (12 generated)
Description was changed from ========== Move the check icon of menu to the right BUG=725784 ========== to ========== Move the check icon of menu to the right screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view BUG=725784 ==========
martiw@chromium.org changed reviewers: + mdjones@chromium.org
PTAL. thanks~!
https://codereview.chromium.org/2901913003/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/translate_menu_item_checked.xml (right): https://codereview.chromium.org/2901913003/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/translate_menu_item_checked.xml:20: android:layout_width="0dp" Why does this width change to 0?
lgtm https://codereview.chromium.org/2901913003/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/translate_menu_item_checked.xml (right): https://codereview.chromium.org/2901913003/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/translate_menu_item_checked.xml:20: android:layout_width="0dp" On 2017/05/24 16:08:00, mdjones wrote: > Why does this width change to 0? I guess layout weight determines the width now.
Thanks Matthew~! https://codereview.chromium.org/2901913003/diff/1/chrome/android/java/res/lay... File chrome/android/java/res/layout/translate_menu_item_checked.xml (right): https://codereview.chromium.org/2901913003/diff/1/chrome/android/java/res/lay... chrome/android/java/res/layout/translate_menu_item_checked.xml:20: android:layout_width="0dp" On 2017/05/24 16:11:49, mdjones wrote: > On 2017/05/24 16:08:00, mdjones wrote: > > Why does this width change to 0? > > I guess layout weight determines the width now. Yes, it uses weight to determine the width now. Otherwise, the check icon at the right will disappear when screen width is not long enough for the menu.
The CQ bit was checked by martiw@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
martiw@chromium.org changed reviewers: + twellington@chromium.org
Hi Theresa, PTAL. need a LGTM from owner. thanks~!
martiw@chromium.org changed reviewers: + yusufo@chromium.org
Hi Yusuf, PTAL. thx. Need a LGTM from owner.
lgtm
On 2017/05/30 15:01:36, Theresa wrote: > lgtm Thanks Theresa!
The CQ bit was checked by martiw@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by martiw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2901913003/#ps20001 (title: "sync & merge")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496190331114320,
"parent_rev": "5bb68a73901bc3d498901f02f9454576c6b033d3", "commit_rev":
"394848886c74b46a456a5eec488a9866b8f86b54"}
Message was sent while issue was closed.
Description was changed from ========== Move the check icon of menu to the right screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view BUG=725784 ========== to ========== Move the check icon of menu to the right screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view BUG=725784 Review-Url: https://codereview.chromium.org/2901913003 Cr-Commit-Position: refs/heads/master@{#475738} Committed: https://chromium.googlesource.com/chromium/src/+/394848886c74b46a456a5eec488a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/394848886c74b46a456a5eec488a... |
