Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2920513003: Revert of devil: Add physical port num to device_status.py (Closed)

Created:
3 years, 6 months ago by bpastene
Modified:
3 years, 6 months ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of devil: Add physical port num to device_status.py (patchset #2 id:20001 of https://codereview.chromium.org/2914063002/ ) Reason for revert: Blocking catapult roll https://chromium-swarm.appspot.com/task?id=3679c73a83445210 Original issue's description: > devil: Add physical port num to device_status.py > > BUG=chromium:719093 > > Review-Url: https://codereview.chromium.org/2914063002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d8e5aec23bc3c86bb12b8b7a33faba22b335e56e TBR=jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:719093 Review-Url: https://codereview.chromium.org/2920513003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/de3ade508f3ff869e7bc63bd6b9a6765afb74774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M devil/devil/android/tools/device_status.py View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bpastene
Created Revert of devil: Add physical port num to device_status.py
3 years, 6 months ago (2017-06-01 00:40:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920513003/1
3 years, 6 months ago (2017-06-01 00:40:49 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-01 00:40:51 UTC) #5
jbudorick
lgtm
3 years, 6 months ago (2017-06-01 00:41:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920513003/1
3 years, 6 months ago (2017-06-01 00:42:49 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:42:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698