Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2914063002: devil: Add physical port num to device_status.py (Closed)

Created:
3 years, 6 months ago by bpastene
Modified:
3 years, 6 months ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add physical port num to device_status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M devil/devil/android/tools/device_status.py View 1 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bpastene
3 years, 6 months ago (2017-05-31 19:30:59 UTC) #3
jbudorick
lgtm
3 years, 6 months ago (2017-05-31 21:01:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914063002/20001
3 years, 6 months ago (2017-05-31 21:10:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d8e5aec23bc3c86bb12b8b7a33faba22b335e56e
3 years, 6 months ago (2017-05-31 21:37:45 UTC) #9
bpastene
3 years, 6 months ago (2017-06-01 00:40:38 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2920513003/ by bpastene@chromium.org.

The reason for reverting is: Blocking catapult roll

https://chromium-swarm.appspot.com/task?id=3679c73a83445210.

Powered by Google App Engine
This is Rietveld 408576698