Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2920303003: [ObjC ARC] Converts ios/web/public/test:test to ARC. (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web/public/test:test to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2920303003 Cr-Commit-Position: refs/heads/master@{#477662} Committed: https://chromium.googlesource.com/chromium/src/+/f338c1654ed5d7ffab5ae4f6822b1a655bd6cc16

Patch Set 1 #

Patch Set 2 : remove .gn workaround #

Patch Set 3 : unsafe_unretained #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M ios/web/public/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/js_test_util.h View 1 2 1 chunk +5 lines, -1 line 1 comment Download
M ios/web/public/test/js_test_util.mm View 1 2 4 chunks +21 lines, -12 lines 0 comments Download
M ios/web/public/test/native_controller_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/navigation_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/scoped_testing_web_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/test_redirect_observer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/web_test.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 2 chunks +7 lines, -3 lines 0 comments Download
M ios/web/public/test/web_view_interaction_test_util.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
baxley
https://codereview.chromium.org/2920303003/diff/40001/ios/web/public/test/js_test_util.h File ios/web/public/test/js_test_util.h (right): https://codereview.chromium.org/2920303003/diff/40001/ios/web/public/test/js_test_util.h#newcode31 ios/web/public/test/js_test_util.h:31: // are converted to ARC. Here's an example where ...
3 years, 6 months ago (2017-06-06 17:16:48 UTC) #4
kkhorimoto
lgtm
3 years, 6 months ago (2017-06-06 20:30:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920303003/40001
3 years, 6 months ago (2017-06-06 21:04:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/231921)
3 years, 6 months ago (2017-06-06 22:22:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920303003/40001
3 years, 6 months ago (2017-06-07 15:30:36 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 15:54:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f338c1654ed5d7ffab5ae4f6822b...

Powered by Google App Engine
This is Rietveld 408576698